<html>
<head><meta charset="utf-8"><title>Need pr reviews · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html">Need pr reviews</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="195959499"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/195959499" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#195959499">(May 01 2020 at 13:14)</a>:</h4>
<p>Is anyone available to review my PRs (<a href="https://github.com/rust-analyzer/rust-analyzer/pull/4043" title="https://github.com/rust-analyzer/rust-analyzer/pull/4043">https://github.com/rust-analyzer/rust-analyzer/pull/4043</a> , <a href="https://github.com/rust-analyzer/rust-analyzer/pull/4207" title="https://github.com/rust-analyzer/rust-analyzer/pull/4207">https://github.com/rust-analyzer/rust-analyzer/pull/4207</a> ) ? in fact I will have some free time this weekend to edit them if needed. So it would be great if you have time to take a look :)</p>



<a name="195967549"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/195967549" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#195967549">(May 01 2020 at 14:43)</a>:</h4>
<p><span class="user-mention" data-user-id="216201">@Edwin Cheng</span>  Thanks for your review. I updated the PR :) I really apreciated</p>



<a name="195971042"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/195971042" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Edwin Cheng <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#195971042">(May 01 2020 at 15:16)</a>:</h4>
<p>You are welcome. <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span>️</p>
<p>I think Github UI is quite complicated that marking it resolved in comments for PR is quite useful for reviewers.</p>



<a name="195984350"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/195984350" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#195984350">(May 01 2020 at 17:15)</a>:</h4>
<p>Ok I marked your comments to resolved :)</p>



<a name="196045439"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/196045439" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#196045439">(May 02 2020 at 10:33)</a>:</h4>
<p><span class="user-mention" data-user-id="133169">@matklad</span>  let me know which limit you prefer :)</p>



<a name="196045441"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/196045441" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#196045441">(May 02 2020 at 10:33)</a>:</h4>
<p><a href="https://github.com/rust-analyzer/rust-analyzer/pull/4207#discussion_r418941382" title="https://github.com/rust-analyzer/rust-analyzer/pull/4207#discussion_r418941382">https://github.com/rust-analyzer/rust-analyzer/pull/4207#discussion_r418941382</a></p>



<a name="196148769"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/196148769" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#196148769">(May 04 2020 at 07:34)</a>:</h4>
<p><span class="user-mention" data-user-id="216201">@Edwin Cheng</span>  do you want I make a PR to resolve this comment <a href="https://github.com/rust-analyzer/rust-analyzer/pull/4285#discussion_r419200375" title="https://github.com/rust-analyzer/rust-analyzer/pull/4285#discussion_r419200375">https://github.com/rust-analyzer/rust-analyzer/pull/4285#discussion_r419200375</a> ?</p>



<a name="196149630"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/196149630" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Edwin Cheng <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#196149630">(May 04 2020 at 07:46)</a>:</h4>
<p>That would be great &lt;3</p>



<a name="196149826"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/196149826" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#196149826">(May 04 2020 at 07:48)</a>:</h4>
<p>Ok I add this on my TODO list :)</p>



<a name="196174242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/196174242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#196174242">(May 04 2020 at 12:37)</a>:</h4>
<p><span class="user-mention" data-user-id="133169">@matklad</span> is it possible for you to review this PR <a href="https://github.com/rust-analyzer/rust-analyzer/pull/4043" title="https://github.com/rust-analyzer/rust-analyzer/pull/4043">https://github.com/rust-analyzer/rust-analyzer/pull/4043</a> ? It's waiting for review for 2 weeks now and I think this feature is pretty useful. I already use it on some projects. I'm open to any suggests :)</p>



<a name="196174345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/196174345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#196174345">(May 04 2020 at 12:38)</a>:</h4>
<p>I'll try to get to it this week :)</p>



<a name="196174450"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/196174450" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#196174450">(May 04 2020 at 12:39)</a>:</h4>
<p>Thanks a lot :)</p>



<a name="196656639"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Need%20pr%20reviews/near/196656639" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Coenen Benjamin <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Need.20pr.20reviews.html#196656639">(May 06 2020 at 16:03)</a>:</h4>
<p><span class="user-mention" data-user-id="133169">@matklad</span> if you have time I finished your review here <a href="https://github.com/rust-analyzer/rust-analyzer/pull/4043" title="https://github.com/rust-analyzer/rust-analyzer/pull/4043">https://github.com/rust-analyzer/rust-analyzer/pull/4043</a> :D</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>